London | 25-SDC-July | Rihanna Poursoltani | Sprint 2 | Improve code with precomputing#89
Open
RihannaP wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Conversation
RihannaP
added
📅 Sprint 2
cjyuan
reviewed
Feb 15, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good. Can you explain using big-O notation why your approach is better?
cjyuan
added
Reviewed
cjyuan
reviewed
Feb 15, 2026
| if len(strings) < 2: | ||
| return "" | ||
|
|
||
| strings.sort() |
There was a problem hiding this comment.
strings.sort() can modify the original list passed into the function by the caller.
How can you prevent this side effect?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
For optimising I tried to
Questions
No question